Skip to content

fix: [Confluence] download_attachments_from_page: the return value from the response is bytes. #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix: [Confluence] download_attachments_from_page: the return value from the response is bytes. #1510

merged 1 commit into from
Mar 21, 2025
+3 −3

Conversation

mgomes-d
Copy link
Contributor

  • Adjusted the download logic to process the file content directly as bytes.

@mgomes-d
fix: the return value from the response is bytes.
cca91e9 
- Adjusted the download logic to process the file content directly as bytes.
@mgomes-d mgomes-d changed the title fix: the return value from the response is bytes. fix: confluence class, function download_attachments_from_page: the return value from the response is bytes. Mar 18, 2025
@mgomes-d mgomes-d changed the title fix: confluence class, function download_attachments_from_page: the return value from the response is bytes. fix: [Confluence] download_attachments_from_page: the return value from the response is bytes. Mar 18, 2025
@meyerjo1SICKAG
Copy link

I think one additinally should add , absolute=True to the request as in line 1471 https://github.com/mgomes-d/atlassian-python-api/blob/cca91e9dc942c57d61027089ef656fbc7366a071/atlassian/confluence.py#L1471 the self.url is prepended to the link. Alternatively, one could just use the download link and let the requests library handle that.

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.06%. Comparing base (c2f3382) to head (cca91e9).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/confluence.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   34.06%   34.06%           
=======================================
  Files          46       46           
  Lines        8832     8832           
  Branches     1352     1352           
=======================================
  Hits         3009     3009           
- Misses       5698     5702    +4     
+ Partials      125      121    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gonchik gonchik merged commit 1e92d70 into atlassian-api:master Mar 21, 2025
12 of 13 checks passed
@mgomes-d mgomes-d deleted the fix/confluence_download_attachments_from_page branch April 15, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgomes-d @meyerjo1SICKAG @gonchik